smolnar82 commented on a change in pull request #65: KNOX-1774 - Introducing environment variables in gateway/knoxcli/ldap/knoxshell scripts for customization URL: https://github.com/apache/knox/pull/65#discussion_r263787333
########## File path: gateway-release-common/.gitignore ########## @@ -0,0 +1,6 @@ +target/ Review comment: The top-level `.gitignore` has this: ``` ... target ``` If it was `**/target` then it would be true, but it's not...I also do not think it's causing any harm here, right? ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
