risdenk commented on a change in pull request #65: KNOX-1774 - Introducing environment variables in gateway/knoxcli/ldap/knoxshell scripts for customization URL: https://github.com/apache/knox/pull/65#discussion_r263788137
########## File path: gateway-release-common/.gitignore ########## @@ -0,0 +1,6 @@ +target/ Review comment: We have 4 .gitignore currently . We only really have one top level .gitignore. 2 others are used as directory placeholders. The last one is for the gateway-admin-ui generated stuff. I don't think another .gitignore in gateway-release-common is necessary. We have target in other module directories that is generated as part of `mvn` and automatically ignored by the top level .gitignore. Not sure why it would be different in this case. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
