smolnar82 commented on issue #65: KNOX-1774 - Introducing environment variables in gateway/knoxcli/ldap/knoxshell scripts for customization URL: https://github.com/apache/knox/pull/65#issuecomment-470941856 > Left some initial comments. I need to look through it closer. > > I think the biggest concern is that we ensure our packaging is correct. tar.gz / zip files end up with all the right files (and permissions) especially the source distributions. I checked the ZIPs we create and that was OK (should not make any difference for .tgz); will check out your recommendation on having `gateway-release-common` a dependency for `gateway-release` to see if we really need to touch the assembly descriptor...
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
