[
https://issues.apache.org/jira/browse/KNOX-1815?focusedWorklogId=210336&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-210336
]
ASF GitHub Bot logged work on KNOX-1815:
----------------------------------------
Author: ASF GitHub Bot
Created on: 08/Mar/19 20:17
Start Date: 08/Mar/19 20:17
Worklog Time Spent: 10m
Work Description: smolnar82 commented on pull request #67: KNOX-1815 -
Removed Windows scripts
URL: https://github.com/apache/knox/pull/67
## What changes were proposed in this pull request?
Removed Windows-based shell scripts since they became outdated and no one
seems to care about them (encouraged by others on the related discussion thread
too).
## How was this patch tested?
Issued `mvn -Ppackage,release package -DskipTests` and checked the final
distribution:
```
$ cd /Users/smolnar/projects/knox/target/1.3.0-SNAPSHOT
$ ls -al
total 877160
drwxr-xr-x 19 smolnar staff 646 Mar 8 20:56 .
drwxr-xr-x 12 smolnar staff 408 Mar 7 14:43 ..
-rw-r--r-- 1 smolnar staff 194575889 Mar 8 20:53
knox-1.3.0-SNAPSHOT-src.zip
-rw-r--r-- 1 smolnar staff 65 Mar 8 20:54
knox-1.3.0-SNAPSHOT-src.zip.sha256
-rw-r--r-- 1 smolnar staff 129 Mar 8 20:54
knox-1.3.0-SNAPSHOT-src.zip.sha512
-rw-r--r-- 1 smolnar staff 113620144 Mar 8 20:54
knox-1.3.0-SNAPSHOT.tar.gz
-rw-r--r-- 1 smolnar staff 65 Mar 8 20:54
knox-1.3.0-SNAPSHOT.tar.gz.sha256
-rw-r--r-- 1 smolnar staff 129 Mar 8 20:54
knox-1.3.0-SNAPSHOT.tar.gz.sha512
-rw-r--r-- 1 smolnar staff 114197541 Mar 8 20:54 knox-1.3.0-SNAPSHOT.zip
-rw-r--r-- 1 smolnar staff 65 Mar 8 20:54
knox-1.3.0-SNAPSHOT.zip.sha256
-rw-r--r-- 1 smolnar staff 129 Mar 8 20:54
knox-1.3.0-SNAPSHOT.zip.sha512
-rw-r--r-- 1 smolnar staff 13319971 Mar 8 20:55
knoxshell-1.3.0-SNAPSHOT.tar.gz
-rw-r--r-- 1 smolnar staff 65 Mar 8 20:55
knoxshell-1.3.0-SNAPSHOT.tar.gz.sha256
-rw-r--r-- 1 smolnar staff 129 Mar 8 20:55
knoxshell-1.3.0-SNAPSHOT.tar.gz.sha512
-rw-r--r-- 1 smolnar staff 13344176 Mar 8 20:55
knoxshell-1.3.0-SNAPSHOT.zip
-rw-r--r-- 1 smolnar staff 65 Mar 8 20:55
knoxshell-1.3.0-SNAPSHOT.zip.sha256
-rw-r--r-- 1 smolnar staff 129 Mar 8 20:55
knoxshell-1.3.0-SNAPSHOT.zip.sha512
$ unzip -q knox-1.3.0-SNAPSHOT.zip
$ ls -al knox-1.3.0-SNAPSHOT/bin/
total 256
drwxr--r-- 12 smolnar staff 408 Mar 8 20:52 .
drwxr--r-- 17 smolnar staff 578 Feb 3 20:30 ..
-rw-r--r-- 1 smolnar staff 22699 Mar 8 20:53 gateway.jar
-rwxr-xr-x 1 smolnar staff 6807 Mar 8 20:51 gateway.sh
-rw-r--r-- 1 smolnar staff 1024 Feb 3 20:30 gateway.xml
-rwxr-xr-x 1 smolnar staff 1907 Mar 8 20:51 knox-env.sh
-rw-r--r-- 1 smolnar staff 22664 Mar 8 20:53 knoxcli.jar
-rwxr-xr-x 1 smolnar staff 1769 Mar 8 20:51 knoxcli.sh
-rw-r--r-- 1 smolnar staff 22732 Mar 8 20:53 ldap.jar
-rwxr-xr-x 1 smolnar staff 6354 Mar 8 20:51 ldap.sh
-rw-r--r-- 1 smolnar staff 1059 Feb 3 20:30 ldap.xml
-rw-r--r-- 1 smolnar staff 22696 Mar 8 20:53 shell.jar
$ unzip -q knoxshell-1.3.0-SNAPSHOT.zip
$ ls -al knoxshell-1.3.0-SNAPSHOT/bin/
total 29072
drwxr--r-- 5 smolnar staff 170 Mar 8 20:52 .
drwxr--r-- 8 smolnar staff 272 Feb 3 20:30 ..
-rwxr-xr-x 1 smolnar staff 1907 Mar 8 20:51 knox-env.sh
-rw-r--r-- 1 smolnar staff 14873793 Mar 8 20:55 knoxshell.jar
-rwxr-xr-x 1 smolnar staff 3568 Mar 8 20:51 knoxshell.sh
```
Result: there is no `.cmd` files in the final ZIPs (the same is true for
TGZs).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 210336)
Time Spent: 10m
Remaining Estimate: 0h
> Windows scripts removal
> -----------------------
>
> Key: KNOX-1815
> URL: https://issues.apache.org/jira/browse/KNOX-1815
> Project: Apache Knox
> Issue Type: Improvement
> Components: KnoxCLI, KnoxShell, Server
> Reporter: Sandor Molnar
> Assignee: Sandor Molnar
> Priority: Major
> Fix For: 1.3.0
>
> Time Spent: 10m
> Remaining Estimate: 0h
>
> Working on KNOX-1774 I realized that [gateway|knoxcli|ldap|knoxshell].cmd
> files haven't been kept up to date with any other scripts. Started a DISCUSS
> thread about this topic where I recommended to remove them all; so far two +1
> received.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
