smolnar82 commented on issue #68: KNOX-1814 - Moving conf/data folder checking 
to Java layer from bash
URL: https://github.com/apache/knox/pull/68#issuecomment-471549008
 
 
   > @smolnar82 what happens previously with a misconfigured directory?
   > 
   > ```shell
   > ./knox-1.3.0-SNAPSHOT/bin/gateway.sh start
   > Starting Gateway succeeded with PID 32349.
   > ```
   > 
   > I would kind of expect that the gateway wouldn't even say start was 
successful.
   
   I agree, but this is how the bash script checks if the service started (as 
of now). A new JIRA should be filed for an enhanced status check (e.g. not 
purely relying on the process being created and a PID is associated). But this 
is outside of the scope of this JIRA. Any objection? 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to