risdenk commented on a change in pull request #69: KNOX-1812 - The Knox Gateway
truststore should be configurable
URL: https://github.com/apache/knox/pull/69#discussion_r264269996
##########
File path:
gateway-server/src/test/java/org/apache/knox/gateway/config/impl/GatewayConfigImplTest.java
##########
@@ -348,4 +348,43 @@ public void testCustomIdentityKeystoreOptions() {
assertEquals("custom_keystore_password_alias",
config.getSigningKeystorePasswordAlias());
}
+ @Test
+ public void testHttpClientTruststoreOptions() {
+ GatewayConfigImpl config = new GatewayConfigImpl();
+
+ // Validate default options (backwards compatibility)
+ assertEquals("gateway-httpclient-truststore-password",
config.getHttpClientTruststorePasswordAlias());
+ assertEquals("JKS", config.getHttpClientTruststoreType());
+ assertNull(config.getHttpClientTruststorePath());
+
+ // Validate changed options
+ config.set("gateway.httpclient.truststore.password.alias",
"custom_password_alias");
Review comment:
Can we use the gatewayconfig constants here?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
