[
https://issues.apache.org/jira/browse/KNOX-1820?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16790541#comment-16790541
]
Robert Levas commented on KNOX-1820:
------------------------------------
[~krisden]
{quote}
Do we still need CMFKeystoreService? Looks like it is only used in
CMFKeystoreServiceTest
{quote}
I have asked this several times and could not get a clear answer. Do we know
what CMF stands for? There is also a CMFMasterService, however it does not
(explicitly) use the CMFKeystoreService.
> Cleanup KeystoreService implementations and add unit tests
> ----------------------------------------------------------
>
> Key: KNOX-1820
> URL: https://issues.apache.org/jira/browse/KNOX-1820
> Project: Apache Knox
> Issue Type: Improvement
> Components: Server
> Reporter: Robert Levas
> Assignee: Robert Levas
> Priority: Minor
> Labels: cleanup
> Fix For: 1.3.0
>
>
> {{org.apache.knox.gateway.services.security.impl.BaseKeystoreService}} should
> be an abstract class extended by
> {{org.apache.knox.gateway.services.security.impl.CMFKeystoreService}} and
> {{DefaultKeystoreService}.
> Unit test for these classes are missing and should be added.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)