[
https://issues.apache.org/jira/browse/KNOX-1828?focusedWorklogId=215464&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-215464
]
ASF GitHub Bot logged work on KNOX-1828:
----------------------------------------
Author: ASF GitHub Bot
Created on: 19/Mar/19 13:46
Start Date: 19/Mar/19 13:46
Worklog Time Spent: 10m
Work Description: shawnweeks commented on pull request #75: KNOX-1828 Fix
Websocket Message Size
URL: https://github.com/apache/knox/pull/75#discussion_r266893301
##########
File path:
gateway-server/src/main/java/org/apache/knox/gateway/websockets/ProxyWebSocketAdapter.java
##########
@@ -87,6 +87,10 @@ public void onWebSocketConnect(final Session
frontEndSession) {
* plumbing takes place
*/
container = ContainerProvider.getWebSocketContainer();
+
container.setDefaultMaxTextMessageBufferSize(frontEndSession.getPolicy().getMaxTextMessageBufferSize());
Review comment:
@moresandeep Yes, the values that are being set for the servlet factory get
applied to any session for the frontEndSession. I'm just copying them to client
container. Since the container is the generic type I can't actually set the max
text message size policy but I've looked at the Jetty code and setting the
buffer also sets the message size.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 215464)
Time Spent: 3h 10m (was: 3h)
> Websocket Parameters Not Being Applied
> --------------------------------------
>
> Key: KNOX-1828
> URL: https://issues.apache.org/jira/browse/KNOX-1828
> Project: Apache Knox
> Issue Type: Bug
> Affects Versions: 1.0.0, 1.1.0, 1.2.0
> Reporter: Shawn Weeks
> Priority: Minor
> Fix For: 1.3.0
>
> Time Spent: 3h 10m
> Remaining Estimate: 0h
>
> It looks like the gateway.websocket parameters are not making it back to
> Jetty. Knox set's this parameter to Integer.MAX_VALUE and setting the
> parameters like the following have no effect.
> {code:java}
> <property>
> <name>gateway.websocket.input.buffer.size</name>
> <value>1048576</value>
> </property>
> <property>
> <name>gateway.websocket.max.binary.buffer.size</name>
> <value>1048576</value>
> </property>
> <property>
> <name>gateway.websocket.max.binary.size</name>
> <value>1048576</value>
> </property>
> <property>
> <name>gateway.websocket.max.text.buffer.size</name>
> <value>1048576</value>
> </property>
> <property>
> <name>gateway.websocket.max.text.size</name>
> <value>1048576</value>
> </property>
> {code}
>
>
> {code:java}
> 2019-03-16 16:11:43,548 ERROR gateway.websockets
> (ProxyWebSocketAdapter.java:cleanupOnError(171)) - Error:
> org.eclipse.jetty.websocket.api.MessageTooLargeException: Resulting message
> size [73,728] is too large for configured max of [65,536]
> {code}
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
