[
https://issues.apache.org/jira/browse/KNOX-1851?focusedWorklogId=226331&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-226331
]
ASF GitHub Bot logged work on KNOX-1851:
----------------------------------------
Author: ASF GitHub Bot
Created on: 11/Apr/19 20:23
Start Date: 11/Apr/19 20:23
Worklog Time Spent: 10m
Work Description: moresandeep commented on pull request #87: KNOX-1851 -
remove the unnecessary instanceof check
URL: https://github.com/apache/knox/pull/87
## What changes were proposed in this pull request?
This is just a cleanup for the previous patch. Removing the unnecessary
`registryClientService instanceof ZooKeeperClientService` check so that the
ZookeeperRemoteAliasServiceProvider can be generic and not dependent on the
ZooKeeperClientService.
## How was this patch tested?
Tested locally on my machine with local ZK instance.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 226331)
Time Spent: 0.5h (was: 20m)
> NPE on startup when Zookeeper Remote Alias Service is configured
> ----------------------------------------------------------------
>
> Key: KNOX-1851
> URL: https://issues.apache.org/jira/browse/KNOX-1851
> Project: Apache Knox
> Issue Type: Bug
> Components: Server
> Affects Versions: 1.3.0
> Reporter: Sandeep More
> Assignee: Sandeep More
> Priority: Major
> Fix For: 1.3.0
>
> Attachments: KNOX-1851.001.patch
>
> Time Spent: 0.5h
> Remaining Estimate: 0h
>
> When ZK remote alias service is configured Knox fails to start with the
> following NPE
> {code:java}
> 2019-04-09 16:34:47,894 FATAL knox.gateway (GatewayServer.java:main(177)) -
> Failed to start gateway: java.lang.NullPointerException
> java.lang.NullPointerException
> at
> org.apache.knox.gateway.services.security.impl.ZookeeperRemoteAliasService.ensureEntry(ZookeeperRemoteAliasService.java:120)
> at
> org.apache.knox.gateway.services.security.impl.ZookeeperRemoteAliasService.ensureEntries(ZookeeperRemoteAliasService.java:408)
> at
> org.apache.knox.gateway.services.security.impl.ZookeeperRemoteAliasService.init(ZookeeperRemoteAliasService.java:326)
> at
> org.apache.knox.gateway.services.security.impl.RemoteAliasService.init(RemoteAliasService.java:260)
> at
> org.apache.knox.gateway.services.DefaultGatewayServices.init(DefaultGatewayServices.java:91)
> at org.apache.knox.gateway.GatewayServer.main(GatewayServer.java:168)
> at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
> at
> sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
> at
> sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
> at java.lang.reflect.Method.invoke(Method.java:498)
> at
> org.apache.knox.gateway.launcher.Invoker.invokeMainMethod(Invoker.java:68)
> at org.apache.knox.gateway.launcher.Invoker.invoke(Invoker.java:39)
> at org.apache.knox.gateway.launcher.Command.run(Command.java:99)
> at org.apache.knox.gateway.launcher.Launcher.run(Launcher.java:75)
> at org.apache.knox.gateway.launcher.Launcher.main(Launcher.java:52)
> {code}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
