risdenk commented on a change in pull request #90: KNOX-1858 - Add service name 
to X-Forwarded-Context header
URL: https://github.com/apache/knox/pull/90#discussion_r285288366
 
 

 ##########
 File path: gateway-release/home/conf/gateway-site.xml
 ##########
 @@ -139,5 +139,10 @@ limitations under the License.
         <description>The whitelist to be applied for dispatches associated 
with the service roles specified by gateway.dispatch.whitelist.services.
         If the value is DEFAULT, a domain-based whitelist will be derived from 
the Knox host.</description>
     </property>
+    <property>
+        <name>gateway.header.x-forward-context.append.servicename</name>
 
 Review comment:
   `private static final String XFORWARDED_ENABLED = GATEWAY_CONFIG_FILE_PREFIX 
+ ".xforwarded.enabled";`
   
   There is an existing config that is `xforwarded`. I think it would be better 
for the config to be:
   
   `gateway.xforwarded.header.context.append.servicename`
   
   or something like that to make it clear these are related.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to