[
https://issues.apache.org/jira/browse/KNOX-1856?focusedWorklogId=246676&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-246676
]
ASF GitHub Bot logged work on KNOX-1856:
----------------------------------------
Author: ASF GitHub Bot
Created on: 22/May/19 11:35
Start Date: 22/May/19 11:35
Worklog Time Spent: 10m
Work Description: smolnar82 commented on issue #92: KNOX-1856 - Using the
appropriate error messages when throwing exception in case there is no public
cert for the gateway or the cert is not an X509Certificate
URL: https://github.com/apache/knox/pull/92#issuecomment-494765246
@rlevas @risdenk @moresandeep
Could you please review my change?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 246676)
Time Spent: 20m (was: 10m)
> Incorrect error message in case there is no 'gateway-identity' certificate in
> the configured keystore
> -----------------------------------------------------------------------------------------------------
>
> Key: KNOX-1856
> URL: https://issues.apache.org/jira/browse/KNOX-1856
> Project: Apache Knox
> Issue Type: Improvement
> Affects Versions: 1.2.0
> Reporter: Sandor Molnar
> Assignee: Sandor Molnar
> Priority: Major
> Time Spent: 20m
> Remaining Estimate: 0h
>
> See the following {{if-else}} branch within
> {{org.apache.knox.gateway.services.security.impl.JettySSLService.logAndValidateCertificate(GatewayConfig)}}
> :
> {code}
> if (cert != null) {
> if (cert instanceof X509Certificate) {
> ...
> } else {
> throw new ServiceLifecycleException("Public certificate for the
> gateway cannot be found with the alias gateway-identity. Plase check the
> identity certificate alias.");
> }
> } else {
> throw new ServiceLifecycleException("Public certificate for the gateway
> is not of the expected type of X509Certificate. Something is wrong with the
> gateway keystore.");
> }
> {code}
> As you can see the actions within the {{'else'}} branches are swapped:
> - in case the {{cert}} is null we should indicate that it's not found
> - in case the {{cert}} is not an {{X509Certificate}} we should say that
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
