risdenk commented on issue #104: DefaultKeystoreService should use Java NIO API locking as well URL: https://github.com/apache/knox/pull/104#issuecomment-504503938 Reading a `KeyStore` from disk is done in 2 places: * `isKeyStoreAvailable` * `loadKeyStore` In all both cases, a new `KeyStore` instance is created. In `loadKeyStore` the new `KeyStore` instance is returned and can be used by the callers without synchronization issues. Writing a `KeyStore` is done in 1 place: * `writeKeyStoreToFile` In every case `writeKeyStoreToFile` is used, it is a new `KeyStore` instance. Either from `loadKeyStore` or a brand new `KeyStore` in `createKeyStore`.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
