smolnar82 opened a new pull request #113: KNOX-1919 - Taking gateway.path into 
consideration when processing redirectToUrl provider param with the OOTB 
knoxsso.xml sample
URL: https://github.com/apache/knox/pull/113
 
 
   ## What changes were proposed in this pull request?
   
   Before my change, the `redirectToUrl` parameter in the OOTB `knoxsso.xml` 
topology was hardcoded to `/gateway/knoxsso/knoxauth/login.html`. In case we 
changed the `gateway.path` configuration element the admin UI became 
unreachable. If you knew where to find the root cause it was easy to fix it, 
but we can do this smarter.
   I changed the sample URL to `/${GATEWAY_PATH}/knoxsso/knoxauth/login.html` 
and made sure to replace the `${GATEWAY_PATH}` placeholder with the actual 
value of `gateway.path`.
   
   ## How was this patch tested?
   
   Tested manually as follows: 
   
   1. changed `gateway.path` to `smolnar_test` in `gateway-site.xml`
   2. restarted the server
   3. hit the following URL: 
`https://localhost:8443/smolnar_test/manager/admin-ui/`
   4. as expected I got redirected to the proper URL
   
   <img width="1674" alt="Screen Shot 2019-07-10 at 3 36 09 PM" 
src="https://user-images.githubusercontent.com/34065904/60976271-ab0b2180-a32d-11e9-981f-6ceb7eab0237.png";>
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to