risdenk commented on a change in pull request #114: KNOX-1816 - Optionally
added shellcheck validation to our build and fixed issues shellcheck already
found
URL: https://github.com/apache/knox/pull/114#discussion_r302984176
##########
File path: gateway-shell-release/pom.xml
##########
@@ -168,6 +169,40 @@
</plugins>
</build>
</profile>
+ <profile>
+ <!-- Running this profile require you to have the 'shellcheck' tool
installed on your DEV environment. Check out
https://github.com/koalaman/shellcheck#installing for more information -->
+ <activation>
+ <property>
+ <name>shellcheck</name>
+ <value>true</value>
+ </property>
+ </activation>
+ <build>
+ <plugins>
+ <plugin>
+ <groupId>org.codehaus.mojo</groupId>
+ <artifactId>exec-maven-plugin</artifactId>
Review comment:
Looks like missing version here?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
