[
https://issues.apache.org/jira/browse/KNOX-1816?focusedWorklogId=275920&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-275920
]
ASF GitHub Bot logged work on KNOX-1816:
----------------------------------------
Author: ASF GitHub Bot
Created on: 12/Jul/19 13:36
Start Date: 12/Jul/19 13:36
Worklog Time Spent: 10m
Work Description: risdenk commented on pull request #114: KNOX-1816 -
Optionally added shellcheck validation to our build and fixed issues shellcheck
already found
URL: https://github.com/apache/knox/pull/114#discussion_r302984176
##########
File path: gateway-shell-release/pom.xml
##########
@@ -168,6 +169,40 @@
</plugins>
</build>
</profile>
+ <profile>
+ <!-- Running this profile require you to have the 'shellcheck' tool
installed on your DEV environment. Check out
https://github.com/koalaman/shellcheck#installing for more information -->
+ <activation>
+ <property>
+ <name>shellcheck</name>
+ <value>true</value>
+ </property>
+ </activation>
+ <build>
+ <plugins>
+ <plugin>
+ <groupId>org.codehaus.mojo</groupId>
+ <artifactId>exec-maven-plugin</artifactId>
Review comment:
Looks like missing version here?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 275920)
Time Spent: 1h 20m (was: 1h 10m)
> Execute shellcheck on our Linux scripts
> ---------------------------------------
>
> Key: KNOX-1816
> URL: https://issues.apache.org/jira/browse/KNOX-1816
> Project: Apache Knox
> Issue Type: Improvement
> Components: KnoxCLI, KnoxShell, Server
> Reporter: Sandor Molnar
> Assignee: Sandor Molnar
> Priority: Minor
> Fix For: 1.4.0
>
> Time Spent: 1h 20m
> Remaining Estimate: 0h
>
> It's strongly recommended to execute {{shellcheck}} on the following Linux
> scripts:
> * {{gateway-release/home/bin/gateway.sh}}
> * {{gateway-release/home/bin/knoxcli.sh}}
> * {{gateway-release/home/bin/ldap.sh}}
> * {{gateway-shell-release/home/bin/knoxshell.sh}}
> It can be done online ([https://www.shellcheck.net/]) or locally after
> installing the software. Once the check has been executed we should apply the
> changes the tool recommends to avoid common bash pitfalls.
> Optionally: we may integrate it with our Travis CI build (needs investigation)
--
This message was sent by Atlassian JIRA
(v7.6.14#76016)
