smolnar82 opened a new pull request #115: KNOX-1922 - Processing a DNSName only if the hostname starts with a letter URL: https://github.com/apache/knox/pull/115 ## What changes were proposed in this pull request? Checking if hostname starts with a letter before generating a `DNSName` with it. ## How was this patch tested? Running JUnit test with Oracle JDK u151 (I was able to reproduce this issue with that JDK): ``` $ export JAVA_HOME=/Library/Java/JavaVirtualMachines/jdk1.8.0_151.jdk/Contents/Home/jre/ $ java -version java version "1.8.0_151" Java(TM) SE Runtime Environment (build 1.8.0_151-b12) Java HotSpot(TM) 64-Bit Server VM (build 25.151-b12, mixed mode) $ mvn clean -T1C verify -Prelease,package ... [INFO] ------------------------------------------------------------------------ [INFO] BUILD SUCCESS [INFO] ------------------------------------------------------------------------ [INFO] Total time: 27:04 min (Wall Clock) [INFO] Finished at: 2019-07-16T11:08:16+02:00 [INFO] Final Memory: 380M/2163M [INFO] ------------------------------------------------------------------------ ``` Started the Knox Gateway using the same JDK (u151); previously it did not start due to the `DNSName components must begin with a letter` issue): ``` $ export JAVA_HOME=/Library/Java/JavaVirtualMachines/jdk1.8.0_151.jdk/Contents/Home/jre/ $ bin/gateway.sh start Starting Gateway succeeded with PID 13456. ps -ef | grep gateway 502 13456 1 0 1:05PM ttys001 0:16.58 /Library/Java/JavaVirtualMachines/jdk1.8.0_151.jdk/Contents/Home/jre//bin/java -Djava.library.path=/Users/smolnar/test/knoxGateway/ext/native -jar /Users/smolnar/test/knoxGateway/bin/gateway.jar ``` I was able to login to admin UI and edit the sandbox topology. ```
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
