Excellent, @kevin and @sandor. Nice work chasing down the issue and getting the fix ready and in!
Here is my -1 for RC 1. I will spin RC 2 today. On Tue, Jul 16, 2019 at 11:22 AM Kevin Risden <[email protected]> wrote: > https://issues.apache.org/jira/browse/KNOX-1922 fixed, tested, and merged > - > pushed to master and v1.3.0. > > Kevin Risden > > > On Tue, Jul 16, 2019 at 10:42 AM larry mccay <[email protected]> > wrote: > > > @Sandor - that's great to hear. > > I think getting a fix for this is worth spinning a new RC - if you can > get > > it done in a day or so. > > > > I'll hold off on my -1 for now but think that if a fix lands soon that I > > will want to pull it into the 1.3.0 release. > > > > On Tue, Jul 16, 2019 at 10:14 AM Sandor Molnar > > <[email protected]> > > wrote: > > > > > I filed a JIRA (https://issues.apache.org/jira/browse/KNOX-1922) to > fix > > > this issue in 1.3.0 because it's not only an error in the unit tests > but > > > also prevents the gateway from being started. > > > I'm working on fixing that issue; I'll keep you updated. > > > > > > Sandor > > > > > > On Mon, Jul 15, 2019 at 5:36 PM Jeffrey Rodriguez < > [email protected]> > > > wrote: > > > > > > > Thanks all, for the info. So we are saying it is .a JDK issue. We > > > > should verify it and document it on the release notes so users who > > > > want to build their distribution are able to do so. It is always good > > > > to lower the frustration factor on users. > > > > Give the above I would vote for releasing 1.3. > > > > Regards, > > > > Jeff Rodriguez > > > > > > > > On Mon, Jul 15, 2019 at 5:39 AM Phil Zampino <[email protected]> > > > wrote: > > > > > > > > > > For the sake of providing another data point, I've *not* > encountered > > > > these > > > > > issues with earlier JDK8 builds: > > > > > > > > > > java version "1.8.0_144" > > > > > Java(TM) SE Runtime Environment (build 1.8.0_144-b01) > > > > > Java HotSpot(TM) 64-Bit Server VM (build 25.144-b01, mixed mode) > > > > > > > > > > > > > > > On Mon, Jul 15, 2019 at 6:42 AM Sandor Molnar > > > > <[email protected]> > > > > > wrote: > > > > > > > > > > > Update: I've just installed Oracle JDK 1.8.0_212 b10 (the latest > > one > > > > > > available on Oracle's download page) and the issue still there. > > > > > > It seems it's only fixed in OpenJDK 1.8.0 u212. > > > > > > > > > > > > On Mon, Jul 15, 2019 at 11:03 AM Sandor Molnar < > > [email protected] > > > > > > > > > > wrote: > > > > > > > > > > > > > > > > > > > > The error you ran into was a known issue in Oracle JDK as well > as > > > in > > > > > > > OpenJDK but both are fixed: > > > > > > > - Oracle JDK - > > > > > > > https://bugs.java.com/bugdatabase/view_bug.do?bug_id=8213952 > > > > > > > - OpenJDK - https://bugs.openjdk.java.net/browse/JDK-8213952 > > > > > > > > > > > > > > Knox's PR builder (Travis CI) uses OpenJDK (sample log: > > > > > > > https://api.travis-ci.org/v3/job/558804721/log.txt): > > > > > > > Java version: 1.8.0_212, vendor: Oracle Corporation, runtime: > > > > > > > /usr/local/openjdk-8/jre > > > > > > > > > > > > > > I experienced the same issue before I upgraded from u151 to > u212 > > > > locally. > > > > > > > > > > > > > > I believe this should not hold back the release. We should only > > > > document > > > > > > > the minimum Java 8 version (update 212) in the release notes. > > > > > > > > > > > > > > Cheers, > > > > > > > Sandor > > > > > > > > > > > > > > On Sat, Jul 13, 2019 at 4:34 PM Jeffrey Rodriguez < > > > > [email protected]> > > > > > > > wrote: > > > > > > > > > > > > > >> Here another attempt to build Knox. > > > > > > >> > > > > > > >> This time in a docker container running alpine version 3.8.2. > > > > > > >> > > > > > > >> Maven 3.6.1 > > > > > > >> Ant 1.9.14 > > > > > > >> Oracle java version "1.8.0_202" > > > > > > >> > > > > > > >> Attached build output. > > > > > > >> > > > > > > >> Regards, > > > > > > >> Jeffrey E Rodriguez > > > > > > >> > > > > > > > > > > > > > > > > > > > > > > >
