[ 
https://issues.apache.org/jira/browse/KNOX-1955?focusedWorklogId=283528&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-283528
 ]

ASF GitHub Bot logged work on KNOX-1955:
----------------------------------------

                Author: ASF GitHub Bot
            Created on: 26/Jul/19 17:54
            Start Date: 26/Jul/19 17:54
    Worklog Time Spent: 10m 
      Work Description: risdenk commented on pull request #123: KNOX-1955 - 
Admin UI should handle gateway.path change
URL: https://github.com/apache/knox/pull/123
 
 
   ## What changes were proposed in this pull request?
   
   Use `window.location` instead of hardcoding the API endpoints
   
   ## How was this patch tested?
   
   * `mvn -T.5C clean verify -Ppackage,release -Dshellcheck`
   * Ran built Knox and updated `gateway.path` in `gateway-site.xml` and 
checked the AdminUI
   
 
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


Issue Time Tracking
-------------------

            Worklog Id:     (was: 283528)
            Time Spent: 10m
    Remaining Estimate: 0h

> Admin UI should handle gateway.path change
> ------------------------------------------
>
>                 Key: KNOX-1955
>                 URL: https://issues.apache.org/jira/browse/KNOX-1955
>             Project: Apache Knox
>          Issue Type: Bug
>          Components: AdminUI
>            Reporter: Kevin Risden
>            Assignee: Kevin Risden
>            Priority: Major
>             Fix For: 1.4.0
>
>          Time Spent: 10m
>  Remaining Estimate: 0h
>
> gateway.path is assumed to be "/gateway/" in the AdminUI. This should instead 
> take gateway.path into account.
> {code:java}
> git grep -F gateway/ -- gateway-admin-ui/ | cat
> gateway-admin-ui/admin-ui/app/gateway-version.service.ts:    private apiUrl = 
> '/gateway/manager/api/v1/version';
> gateway-admin-ui/admin-ui/app/resource/resource.service.ts:    apiUrl = 
> '/gateway/manager/api/v1/';
> gateway-admin-ui/admin-ui/app/topology.service.ts:    apiUrl = 
> '/gateway/manager/api/v1/';
> {code}



--
This message was sent by Atlassian JIRA
(v7.6.14#76016)

Reply via email to