smolnar82 commented on a change in pull request #131: KNOX-1957 - Optional
APP_JAVA_OPTS are handled properly
URL: https://github.com/apache/knox/pull/131#discussion_r316094616
##########
File path: gateway-release-common/home/bin/knox-functions.sh
##########
@@ -181,7 +218,11 @@ function appStart {
rm -f "$APP_PID_FILE"
- nohup "$JAVA" "$APP_JAVA_OPTS" -jar "$APP_JAR" "$@" >>"$APP_OUT_FILE"
2>>"$APP_ERR_FILE" & printf %s $!>"$APP_PID_FILE" || exit 1
+ if [ ${#APP_JAVA_OPTS[@]} -eq 0 ]; then #there is no APP_JAVA_OPTS set
Review comment:
It's working...I just wanted to emphasize the fact that there are no
additional Java opts applied in this case. I changed it anyway; please review.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
