smolnar82 opened a new pull request #133: KNOX-1990 - Making access to System 
properties thread safe while testing non-existing/non-parsable JAAS 
configuration
URL: https://github.com/apache/knox/pull/133
 
 
   ## What changes were proposed in this pull request?
   
   
`RemoteConfigurationRegistryJAASConfigTest.shouldRaiseAnErrorWithMeaningfulErrorMessageXXX`
 fails while Travis CI is building the project upon submitting a new PR (or 
patch) in Github, intermittently.
    
   This was happening due to the parallel JUnit test execution because those 
test cases manipulated the System properties by setting 
valid/non-existing/non-parsable JAAS configuration. To fix this issue I made 
those 3 test methods thread-safe.
   
   ## How was this patch tested?
   
   Executed `mvn clean -Dshellcheck=true -T1C verify -Prelease,package -pl 
gateway-service-remoteconfig` 10 times with the following outcome:
   
   1. before my changes: failed 4 times out of 10
   2. after my changes: succeeded every time
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to