[
https://issues.apache.org/jira/browse/KNOX-1990?focusedWorklogId=298619&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-298619
]
ASF GitHub Bot logged work on KNOX-1990:
----------------------------------------
Author: ASF GitHub Bot
Created on: 21/Aug/19 11:54
Start Date: 21/Aug/19 11:54
Worklog Time Spent: 10m
Work Description: smolnar82 commented on pull request #133: KNOX-1990 -
Making access to System properties thread safe while testing
non-existing/non-parsable JAAS configuration
URL: https://github.com/apache/knox/pull/133
## What changes were proposed in this pull request?
`RemoteConfigurationRegistryJAASConfigTest.shouldRaiseAnErrorWithMeaningfulErrorMessageXXX`
fails while Travis CI is building the project upon submitting a new PR (or
patch) in Github, intermittently.
This was happening due to the parallel JUnit test execution because those
test cases manipulated the System properties by setting
valid/non-existing/non-parsable JAAS configuration. To fix this issue I made
those 3 test methods thread-safe.
## How was this patch tested?
Executed `mvn clean -Dshellcheck=true -T1C verify -Prelease,package -pl
gateway-service-remoteconfig` 10 times with the following outcome:
1. before my changes: failed 4 times out of 10
2. after my changes: succeeded every time
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 298619)
Remaining Estimate: 0h
Time Spent: 10m
> Fix intermittent JUnit test failures in
> RemoteConfigurationRegistryJAASConfigTest
> ---------------------------------------------------------------------------------
>
> Key: KNOX-1990
> URL: https://issues.apache.org/jira/browse/KNOX-1990
> Project: Apache Knox
> Issue Type: Bug
> Components: Tests
> Affects Versions: 1.3.0
> Reporter: Sandor Molnar
> Assignee: Sandor Molnar
> Priority: Major
> Time Spent: 10m
> Remaining Estimate: 0h
>
> {{RemoteConfigurationRegistryJAASConfigTest.shouldRaiseAnErrorWithMeaningfulErrorMessageIfAuthLoginConfigCannotBeRead}}
> fails while Travis CI is building the project upon submitting a new PR (or
> patch) in Github. This is an intermittent issue, but it's very annoying ->
> should be investigated and fixed.
--
This message was sent by Atlassian Jira
(v8.3.2#803003)
