risdenk commented on a change in pull request #135: KNOX-1995 - If a rule 
doesn't match, shouldn't ERROR and return null
URL: https://github.com/apache/knox/pull/135#discussion_r317726104
 
 

 ##########
 File path: 
gateway-provider-rewrite/src/main/java/org/apache/knox/gateway/filter/rewrite/api/UrlRewriteProcessor.java
 ##########
 @@ -165,7 +165,6 @@ public Template rewrite( Resolver resolver, Template 
inputUri, Direction directi
           }
         } else {
           LOG.failedToRewriteUrl( inputUri, direction, effectiveRuleName, 
stepStatus );
-          outputUri = null;
 
 Review comment:
   Yea understood - fixed this in latest patch revision.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to