[
https://issues.apache.org/jira/browse/KNOX-2014?focusedWorklogId=316005&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-316005
]
ASF GitHub Bot logged work on KNOX-2014:
----------------------------------------
Author: ASF GitHub Bot
Created on: 21/Sep/19 00:29
Start Date: 21/Sep/19 00:29
Worklog Time Spent: 10m
Work Description: moresandeep commented on pull request #150: KNOX-2014 -
Make sure ATLASSESSIONID cookie is set
URL: https://github.com/apache/knox/pull/150#discussion_r326838183
##########
File path:
gateway-provider-ha/src/main/java/org/apache/knox/gateway/ha/dispatch/DefaultHaDispatch.java
##########
@@ -39,7 +39,7 @@
/**
* Default HA dispatch class that has a very basic failover mechanism
*/
-public class DefaultHaDispatch extends DefaultDispatch {
+public class DefaultHaDispatch extends ConfigurableDispatch {
Review comment:
Agreed, but the change does not affect the existing features it just adds
the configurability. So, in theory there is really no change. Creating a
separate dispatch, like I mentioned in the PR, would simply duplicate the code,
but I am OK to creating a separate file, just need to to be convinced.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 316005)
Time Spent: 40m (was: 0.5h)
> ATLASSESSIONID cookie missing when Atlas UI proxied via Knox
> ------------------------------------------------------------
>
> Key: KNOX-2014
> URL: https://issues.apache.org/jira/browse/KNOX-2014
> Project: Apache Knox
> Issue Type: Bug
> Components: Server
> Reporter: Sandeep More
> Assignee: Sandeep More
> Priority: Major
> Fix For: 1.4.0
>
> Time Spent: 40m
> Remaining Estimate: 0h
>
> This is similar to KNOX-2011.
> Here there will be some code change needed since Atlas uses customer HA
> dispatch (org.apache.knox.gateway.ha.dispatch.AtlasTrustedProxyHaDispatch)
> based on DefaultDispatch which needs to be updated.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
