[
https://issues.apache.org/jira/browse/KNOX-1914?focusedWorklogId=316864&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-316864
]
ASF GitHub Bot logged work on KNOX-1914:
----------------------------------------
Author: ASF GitHub Bot
Created on: 23/Sep/19 17:42
Start Date: 23/Sep/19 17:42
Worklog Time Spent: 10m
Work Description: pzampino commented on pull request #147: KNOX-1914 -
New admin API to be used by the UI to fetch available service discovery types
URL: https://github.com/apache/knox/pull/147#discussion_r327154152
##########
File path:
gateway-spi/src/main/java/org/apache/knox/gateway/topology/discovery/ServiceDiscoveryFactory.java
##########
@@ -0,0 +1,81 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with this
+ * work for additional information regarding copyright ownership. The ASF
+ * licenses this file to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance with the License.
+ * You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS, WITHOUT
+ * WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the
+ * License for the specific language governing permissions and limitations
under
+ * the License.
+ */
+package org.apache.knox.gateway.topology.discovery;
+
+import java.lang.reflect.Field;
+import java.util.HashSet;
+import java.util.ServiceLoader;
+import java.util.Set;
+
+import org.apache.commons.lang3.ArrayUtils;
+import org.apache.knox.gateway.services.Service;
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
+
+/**
+ * Creates instances of ServiceDiscovery implementations.
+ *
+ * This factory uses the ServiceLoader mechanism to load ServiceDiscovery
+ * implementations as extensions.
+ *
+ */
+public abstract class ServiceDiscoveryFactory {
+
+ private static final Logger LOG =
LoggerFactory.getLogger(ServiceDiscoveryFactory.class);
+
+ private static final Service[] NO_GATEWAY_SERVICS = new Service[] {};
+
+ public static ServiceDiscovery get(String type) {
+ return get(type, NO_GATEWAY_SERVICS);
+ }
+
+ public static Set<ServiceDiscovery> getAllServiceDiscoveries() {
+ final Set<ServiceDiscovery> serviceDiscoveries = new HashSet<>();
+
ServiceLoader.load(ServiceDiscoveryType.class).forEach((serviceDiscoveryType)
-> {
+ serviceDiscoveries.add(serviceDiscoveryType.newInstance());
+ });
+ return serviceDiscoveries;
+ }
+
+ public static ServiceDiscovery get(String type, Service... gatewayServices) {
+ final ServiceDiscovery sd =
getAllServiceDiscoveries().stream().filter(serviceDiscovery ->
serviceDiscovery.getType().equalsIgnoreCase(type)).findFirst().orElse(null);
Review comment:
@smolnar82 sd could result as null in some cases, correct? If so, there
should be some subsequent check, either herein or in injectGatewayServices, to
avoid NPEs.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 316864)
Time Spent: 2h 20m (was: 2h 10m)
> Dynamic population of Admin UI service discovery type options
> -------------------------------------------------------------
>
> Key: KNOX-1914
> URL: https://issues.apache.org/jira/browse/KNOX-1914
> Project: Apache Knox
> Issue Type: Bug
> Components: AdminUI
> Affects Versions: 1.3.0
> Reporter: Phil Zampino
> Assignee: Sandor Molnar
> Priority: Major
> Fix For: 1.4.0
>
> Time Spent: 2h 20m
> Remaining Estimate: 0h
>
> The Discovery Details section of the Admin UI for working with descriptors
> includes a drop-down list of supported discovery providers (e.g., Ambari,
> ClouderaManager). Currently, this list is statically defined in the Admin UI.
> It should be possible to expose an API from the Knox host for determining the
> list of supported discovery providers.
> This API could leverage the same Java service loader mechanism that is used
> by the discovery runtime to load discovery providers.
> This would be nice for two closely-related reasons:
> # Subsequent additional discovery providers implemented in the Knox project
> itself won't require further Admin UI changes.
> # User/Customer discovery provider extensions would get Admin UI support
> automatically.
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
