risdenk commented on a change in pull request #163: KNOX-2052 - KnoxShellTable
mean, median, and mode methods
URL: https://github.com/apache/knox/pull/163#discussion_r332277842
##########
File path:
gateway-shell/src/main/java/org/apache/knox/gateway/shell/table/KnoxShellTable.java
##########
@@ -33,6 +34,9 @@
*/
public class KnoxShellTable {
+ static final int DOUBLE_CONVERSION_METHOD = 0;
+ static final int INTEGER_CONVERSION_METHOD = 1;
+ static final int FLOAT_CONVERSION_METHOD = 2;
Review comment:
An enum might be better here instead of building out an enum manually?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
