lmccay4 commented on a change in pull request #163: KNOX-2052 - KnoxShellTable
mean, median, and mode methods
URL: https://github.com/apache/knox/pull/163#discussion_r334645130
##########
File path:
gateway-shell/src/main/java/org/apache/knox/gateway/shell/table/KnoxShellTable.java
##########
@@ -86,6 +96,172 @@ public KnoxShellTable value(Comparable<? extends Object>
value) {
return col;
}
+ private Conversions getConversion(Comparable<? extends Object> colIndex) {
+ Conversions type = null;
+ if (colIndex instanceof Double) {
+ type = Conversions.DOUBLE;
+ }
+ else if (colIndex instanceof Integer) {
+ type = Conversions.INTEGER;
+ }
+ else if (colIndex instanceof Float) {
+ type = Conversions.FLOAT;
+ }
+ else if (colIndex instanceof Byte) {
+ type = Conversions.BYTE;
+ }
+ else if (colIndex instanceof Short) {
+ type = Conversions.SHORT;
+ }
+ else if (colIndex instanceof Long) {
+ type = Conversions.LONG;
+ }
+ else {
+ throw new IllegalArgumentException();
Review comment:
Thanks for the review! Will follow up with this on another change.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
