[
https://issues.apache.org/jira/browse/KNOX-2057?focusedWorklogId=328441&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-328441
]
ASF GitHub Bot logged work on KNOX-2057:
----------------------------------------
Author: ASF GitHub Bot
Created on: 15/Oct/19 09:23
Start Date: 15/Oct/19 09:23
Worklog Time Spent: 10m
Work Description: risdenk commented on pull request #165: KNOX-2057 -
Using unique table IDs through different test cases even if they are in
different test classes (JVM is shared in during parallel execution)
URL: https://github.com/apache/knox/pull/165#discussion_r334841919
##########
File path:
gateway-shell/src/test/java/org/apache/knox/gateway/shell/table/KnoxShellTableTest.java
##########
@@ -362,11 +362,13 @@ public Object answer() {
@Test
public void shouldReturnDifferentCallHistoryForDifferentTables() throws
Exception {
final KnoxShellTable table1 = new KnoxShellTable();
- table1.id(1);
- KnoxShellTableCallHistory.getInstance().saveCall(1, new
KnoxShellTableCall("class1", "method1", true,
Collections.singletonMap("param1", String.class)));
+ final long id1 = KnoxShellTable.getUniqueTableId();
+ table1.id(id1);
Review comment:
I haven't looked at the implementation but shouldn't a table get a unique ID
automatically? Do we need to set an id on the table? We should be able to ask
the table for the id?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 328441)
Time Spent: 0.5h (was: 20m)
> KnoxShellTableCallHistoryTest failure
> -------------------------------------
>
> Key: KNOX-2057
> URL: https://issues.apache.org/jira/browse/KNOX-2057
> Project: Apache Knox
> Issue Type: Test
> Components: Tests
> Affects Versions: 1.4.0
> Reporter: Kevin Risden
> Assignee: Sandor Molnar
> Priority: Major
> Fix For: 1.4.0
>
> Time Spent: 0.5h
> Remaining Estimate: 0h
>
> New test from KNOX-2023 failed twice on Apache Jenkins server
> https://builds.apache.org/job/Knox-master-daily/8457/org.apache.knox$gateway-shell/testReport/junit/org.apache.knox.gateway.shell.table/KnoxShellTableCallHistoryTest/shouldReturnCallHistoryInProperOrder/
> https://builds.apache.org/job/Knox-master-daily/8458/org.apache.knox$gateway-shell/testReport/org.apache.knox.gateway.shell.table/KnoxShellTableCallHistoryTest/shouldReturnCallHistoryInProperOrder/
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
