smolnar82 commented on issue #164: KNOX-2053 - New REST API to create/read/update/delete service definitions URL: https://github.com/apache/knox/pull/164#issuecomment-542606373 @risdenk - I addressed all of your above-comments: - removed the Guava dependency (created a new utility class to determine if a Collection is sorted) - removed the `commons-lang3` dependency by simply implementing the `toString` method with a `StringBuilder` - synchronized and reduced visibility of marshaller/unmarshaller access - changed the responses in the new API - if successfully processed the `Location` header will indicate the created/updated resource location - if failed the error we return starts with a constant
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
