risdenk commented on a change in pull request #168: KNOX-2060 - Extend
KnoxShellTable statistics methods to work with columns of Strings
URL: https://github.com/apache/knox/pull/168#discussion_r336478118
##########
File path:
gateway-shell/src/test/java/org/apache/knox/gateway/shell/table/KnoxShellTableTest.java
##########
@@ -385,11 +385,15 @@ public void testMean() throws Exception {
Long long20 = (long) 200000000;
Long long30 = (long) 300000000;
+ String string10 = "-10";
+ String string20 = "-20";
+ String string30 = "-30.00";
Review comment:
Need to test positives? Also would do more and less than two digits.
Probably makes sense to randomize this. Random and then multiply to make a
double. Same for the other values
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
