[
https://issues.apache.org/jira/browse/KNOX-2060?focusedWorklogId=330486&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-330486
]
ASF GitHub Bot logged work on KNOX-2060:
----------------------------------------
Author: ASF GitHub Bot
Created on: 18/Oct/19 13:00
Start Date: 18/Oct/19 13:00
Worklog Time Spent: 10m
Work Description: risdenk commented on pull request #168: KNOX-2060 -
Extend KnoxShellTable statistics methods to work with columns of Strings
URL: https://github.com/apache/knox/pull/168#discussion_r336478118
##########
File path:
gateway-shell/src/test/java/org/apache/knox/gateway/shell/table/KnoxShellTableTest.java
##########
@@ -385,11 +385,15 @@ public void testMean() throws Exception {
Long long20 = (long) 200000000;
Long long30 = (long) 300000000;
+ String string10 = "-10";
+ String string20 = "-20";
+ String string30 = "-30.00";
Review comment:
Need to test positives? Also would do more and less than two digits.
Probably makes sense to randomize this. Random and then multiply to make a
double. Same for the other values
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 330486)
Time Spent: 20m (was: 10m)
> Extend KnoxShellTable statistics methods to work with columns of Strings
> ------------------------------------------------------------------------
>
> Key: KNOX-2060
> URL: https://issues.apache.org/jira/browse/KNOX-2060
> Project: Apache Knox
> Issue Type: Improvement
> Components: KnoxShell
> Reporter: Ljmiv
> Assignee: Ljmiv
> Priority: Major
> Fix For: 1.4.0
>
> Time Spent: 20m
> Remaining Estimate: 0h
>
> Convert columns with numbers stored as strings to double arrays to allow for
> statutils operations. Useful as tables will be imported as CSV, resulting in
> columns of strings. No current way to convert strings to double[].
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
