smolnar82 commented on a change in pull request #169: KNOX-2056 - Adding
Service Definitions management into Admin UI
URL: https://github.com/apache/knox/pull/169#discussion_r339468051
##########
File path:
gateway-admin-ui/admin-ui/app/resource-detail/resource-detail.component.html
##########
@@ -551,3 +551,8 @@ <h4 class="modal-title">Discard {{getTitleSubject()}}
Changes</h4>
<div *ngIf="resourceType === 'Topologies'">
<app-topology-detail></app-topology-detail>
</div>
+
+<!-- Service Definition Details -->
+<div *ngIf="resourceType === 'Service Definitions'">
Review comment:
Like you found out this was an existing pattern. I'd use it _as-is_ for now
and I'll create a follow-up JIRA to enhance this part later on).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
