smolnar82 commented on issue #169: KNOX-2056 - Adding Service Definitions management into Admin UI URL: https://github.com/apache/knox/pull/169#issuecomment-546867238 > Nice work, @smolnar82! > I like the paging that you added. > Also, not having to do the restart and topology touch to get rewrite rule changes to take effect is HUGE! Thanks! > I did see an exception thrown on update of a service definition related to URI not being a file schema or something like that. There was a nasty bug in `org.apache.knox.gateway.service.admin.TopologiesResource` which I fixed in a separate commit in this PR. > I'd suggest a follow up JIRA for adding new Service Definition either from scratch with a template to get started or at least a copy from existing like we have for Topologies. See https://issues.apache.org/jira/browse/KNOX-2068
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
