[
https://issues.apache.org/jira/browse/KNOX-2070?focusedWorklogId=335068&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-335068
]
ASF GitHub Bot logged work on KNOX-2070:
----------------------------------------
Author: ASF GitHub Bot
Created on: 28/Oct/19 17:53
Start Date: 28/Oct/19 17:53
Worklog Time Spent: 10m
Work Description: risdenk commented on pull request #170: KNOX-2070 -
SSOCookieFederationFilter NPE
URL: https://github.com/apache/knox/pull/170
## What changes were proposed in this pull request?
Add test for XHR and fix the NPE caused by XHR and invalid cookies.
## How was this patch tested?
`mvn -T.5C clean verify -Ppackage,release -Dshellcheck`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 335068)
Remaining Estimate: 0h
Time Spent: 10m
> SSOCookieFederationFilter NPE
> -----------------------------
>
> Key: KNOX-2070
> URL: https://issues.apache.org/jira/browse/KNOX-2070
> Project: Apache Knox
> Issue Type: Bug
> Components: KnoxSSO
> Reporter: Kevin Risden
> Assignee: Kevin Risden
> Priority: Major
> Fix For: 1.4.0
>
> Time Spent: 10m
> Remaining Estimate: 0h
>
> SSOCookieFederationFilter has a NPE when the error message is null. This can
> happen a few different ways if the token is invalid. It prevents the response
> from being sent correctly.
> {code:java}
> ...
> Caused by: java.lang.NullPointerException
> at
> org.apache.knox.gateway.provider.federation.jwt.filter.SSOCookieFederationFilter.handleValidationError(SSOCookieFederationFilter.java:140)
> at
> org.apache.knox.gateway.provider.federation.jwt.filter.AbstractJWTFilter.validateToken(AbstractJWTFilter.java:299)
> at
> org.apache.knox.gateway.provider.federation.jwt.filter.SSOCookieFederationFilter.doFilter(SSOCookieFederationFilter.java:122)
> at
> org.apache.knox.gateway.GatewayFilter$Holder.doFilter(GatewayFilter.java:349)
> at
> org.apache.knox.gateway.GatewayFilter$Chain.doFilter(GatewayFilter.java:263)
> at
> com.thetransactioncompany.cors.CORSFilter.doFilter(CORSFilter.java:209)
> at
> com.thetransactioncompany.cors.CORSFilter.doFilter(CORSFilter.java:244)
> at
> org.apache.knox.gateway.GatewayFilter$Holder.doFilter(GatewayFilter.java:349)
> at
> org.apache.knox.gateway.GatewayFilter$Chain.doFilter(GatewayFilter.java:263)
> at
> org.apache.knox.gateway.filter.XForwardedHeaderFilter.doFilter(XForwardedHeaderFilter.java:50)
> at
> org.apache.knox.gateway.filter.AbstractGatewayFilter.doFilter(AbstractGatewayFilter.java:58)
> ... 52 more
> {code}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)