[
https://issues.apache.org/jira/browse/KNOX-2025?focusedWorklogId=336092&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-336092
]
ASF GitHub Bot logged work on KNOX-2025:
----------------------------------------
Author: ASF GitHub Bot
Created on: 30/Oct/19 10:01
Start Date: 30/Oct/19 10:01
Worklog Time Spent: 10m
Work Description: smolnar82 commented on pull request #172: KNOX-2025 -
KnoxShellTable - Join Builder on Method should accept Col Names
URL: https://github.com/apache/knox/pull/172#discussion_r340522212
##########
File path:
gateway-shell/src/main/java/org/apache/knox/gateway/shell/table/JoinKnoxShellTableBuilder.java
##########
@@ -52,6 +52,12 @@ public KnoxShellTable on(String columnName) {
return on(leftIndex, rightIndex);
}
+ public KnoxShellTable on(String columnName, String columnName2) {
Review comment:
nit: if I were you I'd use `columnNameLeft` and `columnNameRight` argument
names
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 336092)
Time Spent: 20m (was: 10m)
> KnoxShellTable - Join Builder on Method should accept Col Names
> ---------------------------------------------------------------
>
> Key: KNOX-2025
> URL: https://issues.apache.org/jira/browse/KNOX-2025
> Project: Apache Knox
> Issue Type: Improvement
> Components: KnoxShell
> Reporter: Larry McCay
> Assignee: Ljmiv
> Priority: Major
> Labels: noob
> Fix For: 1.4.0
>
> Time Spent: 20m
> Remaining Estimate: 0h
>
> The on() in the Join builder currently accepts two ints as the 0 based index
> into the cols.
> We need to also be able to join on Col Names - we can just look up the index
> from the names as done in other places already.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
