[
https://issues.apache.org/jira/browse/KNOX-2095?focusedWorklogId=339042&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-339042
]
ASF GitHub Bot logged work on KNOX-2095:
----------------------------------------
Author: ASF GitHub Bot
Created on: 05/Nov/19 23:05
Start Date: 05/Nov/19 23:05
Worklog Time Spent: 10m
Work Description: jameschen1519 commented on issue #177: [WIP] KNOX-2095
- Adding in DefaultDispatch code and tests to handle 504 errors
URL: https://github.com/apache/knox/pull/177#issuecomment-550063704
Hmm. It looks like the check at
https://api.travis-ci.org/v3/job/607855611/log.txt failed, but the logs suggest
that it may be running plugins that aren't thread safe. Assuming that this is a
threading issue, is there any way to rerun the tests, possibly without
parallelism?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 339042)
Remaining Estimate: 167h 40m (was: 167h 50m)
Time Spent: 20m (was: 10m)
> Many errors (E.G. 504s) being masked as 500 errors
> --------------------------------------------------
>
> Key: KNOX-2095
> URL: https://issues.apache.org/jira/browse/KNOX-2095
> Project: Apache Knox
> Issue Type: Improvement
> Affects Versions: 1.2.0, 1.3.0
> Reporter: James Chen
> Assignee: James Chen
> Priority: Minor
> Labels: easyfix
> Fix For: 1.4.0
>
> Attachments: KNOX-2095.patch, jamchen504patch.patch
>
> Original Estimate: 168h
> Time Spent: 20m
> Remaining Estimate: 167h 40m
>
> When errors occur while accessing the Knox gateway, errors are forcibly
> overridden and represented as 500 errors, rather than whatever errors they
> should be.
> For example, when the timeout value under gateway.httpclient.socketTimeout is
> set to a very low timeout value (E.G. 1 ms) under gateway-site.xml, a socket
> timeout exception is produced by the getHttpClient().execute(
> outboundRequest) call. However, this is caught by the surrounding try-catch
> block and thrown again as an IOException. This results in a generic 500
> error, rather than a 504 error one would normally expect from this sort of
> interaction.
>
> For these sorts of scenarios, I believe it would be prudent to create a dummy
> HttpResponse using a HttpResponseFactory object for the inboundResponse with
> the corresponding error code (E.G. HttpStatus.SC_GATEWAY_TIMEOUT in the event
> of a SocketTimeoutException) and return that instead to trigger the
> appropriate 504 error. I suspect there are other sorts of potential error
> code triggers that get this same IOException treatment that would be better
> off receiving their own error codes.
>
> Judging from the source code, this issue likely affects version 1.3.0, though
> this has not been tested.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
