[
https://issues.apache.org/jira/browse/KNOX-2071?focusedWorklogId=339454&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-339454
]
ASF GitHub Bot logged work on KNOX-2071:
----------------------------------------
Author: ASF GitHub Bot
Created on: 06/Nov/19 16:19
Start Date: 06/Nov/19 16:19
Worklog Time Spent: 10m
Work Description: pzampino commented on pull request #178: KNOX-2071 -
Configurable maximum token lifetime for TokenStateService
URL: https://github.com/apache/knox/pull/178#discussion_r343190235
##########
File path:
gateway-spi/src/main/java/org/apache/knox/gateway/services/security/token/TokenStateService.java
##########
@@ -27,22 +27,41 @@
String CONFIG_SERVER_MANAGED = "knox.token.exp.server-managed";
+ /**
+ * @return The default duration (in milliseconds) for which a token's life
will be extended when it is renewed.
+ */
+ long getDefaultRenewInterval();
+
+ /**
+ * @return The default maximum lifetime duration (in milliseconds) of a
token.
+ */
+ long getDefaultMaxLifetimeDuration();
+
/**
* Add state for the specified token.
*
* @param token The token.
* @param issueTime The time the token was issued.
*/
- void addToken(JWTToken token, long issueTime);
-
+ void addToken(JWTToken token, Long issueTime);
Review comment:
I agree, and as I've mentioned, it was an iterative change which is no
longer needed. I'll revert that, and submit an update to this PR.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 339454)
Time Spent: 1h 40m (was: 1.5h)
> Configurable maximum token lifetime for TokenStateService
> ---------------------------------------------------------
>
> Key: KNOX-2071
> URL: https://issues.apache.org/jira/browse/KNOX-2071
> Project: Apache Knox
> Issue Type: Bug
> Components: Server
> Affects Versions: 1.3.0
> Reporter: Philip Zampino
> Assignee: Philip Zampino
> Priority: Minor
> Fix For: 1.4.0
>
> Time Spent: 1h 40m
> Remaining Estimate: 0h
>
> With KNOX-2067, and the ability to renew tokens up to a maximum token
> lifetime, it should be possible to configure this maximum lifetime as either
> a gateway-level configuration item, or as a service param of a deployed
> instance of a token issuing service (e.g., KnoxToken service).
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
