[
https://issues.apache.org/jira/browse/KNOX-2122?focusedWorklogId=342108&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-342108
]
ASF GitHub Bot logged work on KNOX-2122:
----------------------------------------
Author: ASF GitHub Bot
Created on: 12/Nov/19 19:58
Start Date: 12/Nov/19 19:58
Worklog Time Spent: 10m
Work Description: smolnar82 commented on issue #191: KNOX-2122 - Code
cleanup from static code analysis
URL: https://github.com/apache/knox/pull/191#issuecomment-553088880
Let me know if you need another hand here!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 342108)
Time Spent: 20m (was: 10m)
> Code cleanup from static code analysis
> --------------------------------------
>
> Key: KNOX-2122
> URL: https://issues.apache.org/jira/browse/KNOX-2122
> Project: Apache Knox
> Issue Type: Improvement
> Reporter: Kevin Risden
> Assignee: Kevin Risden
> Priority: Minor
> Fix For: 1.4.0
>
> Time Spent: 20m
> Remaining Estimate: 0h
>
> * Diamond operator
> * Static method calls instead of on instances
> * Remove null check before instanceof
> * Use computeIfAbsent where possible
> * Remove simple nested if statements
> * Remove redundant cast
> * Use entrySet for iteration of maps
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
