pzampino commented on a change in pull request #195: KNOX-2126. Add an API to 
retrieve the public key used for Knox JWT verification.
URL: https://github.com/apache/knox/pull/195#discussion_r346995661
 
 

 ##########
 File path: 
gateway-service-knoxtoken/src/test/java/org/apache/knox/gateway/service/knoxtoken/TokenServiceResourceTest.java
 ##########
 @@ -778,6 +785,32 @@ public void 
testTokenRevocation_Enabled_WithRenewersWithValidSubject() throws Ex
     validateSuccessfulRevocationResponse(renewalResponse);
   }
 
+  @Test
+  public void testGetPublicKey() throws Exception {
+    TokenResource tr = createTokenResourceForPublicKeyTests(false);
+
+    Response response = tr.publicKey();
+    assertEquals("Unexpected response code", Status.OK.getStatusCode(), 
response.getStatus());
+    String retString = response.getEntity().toString();
+    Map<String, String> responseMap = parseJSONResponse(retString);
+    assertNotNull("PublicKey is null", 
responseMap.get(TokenResource.PUBLIC_KEY));
+    assertNotNull("Algorithm is null", 
responseMap.get(TokenResource.ALGORITHM));
+    assertEquals("Mismatched algorithm", 
responseMap.get(TokenResource.ALGORITHM),
+        publicKey.getAlgorithm());
+    assertArrayEquals("Mismatched public key",
+        Base64.decodeBase64(responseMap.get(TokenResource.PUBLIC_KEY)), 
publicKey.getEncoded());
+
+  }
+
+  @Test
+  public void testGetPublicKey_error() throws Exception {
+    TokenResource tr = createTokenResourceForPublicKeyTests(true);
+
+    Response response = tr.publicKey();
+    assertEquals("Unexpoected response code", 
Status.INTERNAL_SERVER_ERROR.getStatusCode(),
 
 Review comment:
   Typo: Unexpoected

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to