risdenk commented on a change in pull request #205: KNOX-2134 - Add caching to
ZookeeperRemoteAliasService
URL: https://github.com/apache/knox/pull/205#discussion_r349761544
##########
File path:
gateway-server/src/main/java/org/apache/knox/gateway/services/security/impl/ZookeeperRemoteAliasService.java
##########
@@ -169,19 +171,23 @@ private static void checkPathsExist(
public List<String> getAliasesForCluster(final String clusterName) throws
AliasServiceException {
List<String> remoteAliases = new ArrayList<>();
- /* If we have remote registry configured, query it */
- if (remoteClient != null) {
- remoteAliases = remoteClient
- .listChildEntries(buildClusterEntryName(clusterName));
+ // First, check the alias cache
+ if (aliasCache.containsKey(clusterName)) {
+ remoteAliases.addAll(aliasCache.get(clusterName).keySet());
+ } else { // If it's not available locally, then check ZK
+ /* If we have remote registry configured, query it */
+ if (remoteClient != null) {
+ remoteAliases =
remoteClient.listChildEntries(buildClusterEntryName(clusterName));
+ }
Review comment:
If the cache isn't up to date for whatever reason, we should update the
cache and return that data. Now have to be careful about a race condition here.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
