risdenk commented on a change in pull request #213: KNOX-2136 - Caching
credentials in DefaultKeystoreService when an alias is being added (instead of
the first time someone fetches) and using a different cache implementation
URL: https://github.com/apache/knox/pull/213#discussion_r357211461
##########
File path:
gateway-server/src/main/java/org/apache/knox/gateway/services/security/impl/DefaultKeystoreService.java
##########
@@ -290,6 +294,7 @@ public void addCredentialForCluster(String clusterName,
String alias, String val
final Path keyStoreFilePath = keyStoreDirPath.resolve(clusterName +
CREDENTIALS_SUFFIX);
writeKeyStoreToFile(ks, keyStoreFilePath,
masterService.getMasterSecret());
+ addToCache(clusterName, alias, value);
Review comment:
We want this to happen no matter what right? Maybe in the finally block or
leave it at the beginning?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
