[
https://issues.apache.org/jira/browse/KNOX-2136?focusedWorklogId=358743&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-358743
]
ASF GitHub Bot logged work on KNOX-2136:
----------------------------------------
Author: ASF GitHub Bot
Created on: 12/Dec/19 15:36
Start Date: 12/Dec/19 15:36
Worklog Time Spent: 10m
Work Description: risdenk commented on pull request #213: KNOX-2136 -
Caching credentials in DefaultKeystoreService when an alias is being added
(instead of the first time someone fetches) and using a different cache
implementation
URL: https://github.com/apache/knox/pull/213#discussion_r357211461
##########
File path:
gateway-server/src/main/java/org/apache/knox/gateway/services/security/impl/DefaultKeystoreService.java
##########
@@ -290,6 +294,7 @@ public void addCredentialForCluster(String clusterName,
String alias, String val
final Path keyStoreFilePath = keyStoreDirPath.resolve(clusterName +
CREDENTIALS_SUFFIX);
writeKeyStoreToFile(ks, keyStoreFilePath,
masterService.getMasterSecret());
+ addToCache(clusterName, alias, value);
Review comment:
We want this to happen no matter what right? Maybe in the finally block or
leave it at the beginning?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 358743)
Time Spent: 0.5h (was: 20m)
> Caching for keystore-based AliasService implementation
> ------------------------------------------------------
>
> Key: KNOX-2136
> URL: https://issues.apache.org/jira/browse/KNOX-2136
> Project: Apache Knox
> Issue Type: Improvement
> Components: Server
> Affects Versions: 1.3.0
> Reporter: Philip Zampino
> Assignee: Sandor Molnar
> Priority: Major
> Fix For: 1.4.0
>
> Time Spent: 0.5h
> Remaining Estimate: 0h
>
> Performance testing has revealed that as the number of keys increases, the
> performance of keystores degrades significantly. We should investigate the
> feasibility and potential benefit of adding in-memory caching of aliases in
> the keystore(file)-based AliasService implementation.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
