smolnar82 commented on a change in pull request #213: KNOX-2136 - Caching credentials in DefaultKeystoreService when an alias is being added (instead of the first time someone fetches) and using a different cache implementation URL: https://github.com/apache/knox/pull/213#discussion_r357246508
########## File path: gateway-server/src/main/java/org/apache/knox/gateway/services/security/impl/DefaultKeystoreService.java ########## @@ -71,8 +74,9 @@ private static GatewayMessages LOG = MessagesFactory.get(GatewayMessages.class); private static GatewayResources RES = ResourcesFactory.get(GatewayResources.class); + //let's configure the cache with hard-coded attributes now; we can introduce new gateway configuration later on if needed + private final Cache<String, Map<String, String>> cache = Caffeine.newBuilder().expireAfterWrite(10, TimeUnit.MINUTES).maximumSize(1000).build(); Review comment: I believe it is possible. That rings the bell that we may want to keep the line which adds back an entry into the cache when the credential was loaded from the keystore. Is this you'd like to point out? ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
