risdenk commented on a change in pull request #221: KNOX-1921 - CM discovery -
Hue Load balancer HTTP/HTTPS scheme
URL: https://github.com/apache/knox/pull/221#discussion_r358528667
##########
File path:
gateway-discovery-cm/src/main/java/org/apache/knox/gateway/topology/discovery/cm/collector/HueURLCollector.java
##########
@@ -28,12 +28,27 @@
*/
public class HueURLCollector extends AbstractURLCollector {
+ private static final String SCHEME_HTTP = "http";
+ private static final String SCHEME_HTTPS = "https";
Review comment:
Might make sense to put on abstract url collector since will be used a bunch?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
