risdenk commented on a change in pull request #216: KNOX-2149 -
JWTTokenProvider - JWT verification with OIDC provider by invoking JWKS
verification url
URL: https://github.com/apache/knox/pull/216#discussion_r359111006
##########
File path:
gateway-provider-security-jwt/src/main/java/org/apache/knox/gateway/provider/federation/jwt/filter/JWTFederationFilter.java
##########
@@ -80,6 +92,10 @@ public void doFilter(ServletRequest request,
ServletResponse response, FilterCha
// what follows the bearer designator should be the JWT token being used
to request or as an access token
wireToken = header.substring(BEARER.length());
}
+ else if((((HttpServletRequest) request).getHeader(HEADER_TOKEN_NAME))!=
null) {
Review comment:
Sorry - This is going to be super nitpicky - can this be a separate Jira/PR
for this change for Hive? I want to call it out separately since its not really
the main part of this change. I also wonder why a header with a space can't be
passed. That seems like a weird Hive JDBC restriction that I haven't seen
before.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
