[
https://issues.apache.org/jira/browse/KNOX-2154?focusedWorklogId=361476&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-361476
]
ASF GitHub Bot logged work on KNOX-2154:
----------------------------------------
Author: ASF GitHub Bot
Created on: 19/Dec/19 18:11
Start Date: 19/Dec/19 18:11
Worklog Time Spent: 10m
Work Description: smolnar82 commented on pull request #226: KNOX-2154 -
Allow KNOX service during topology generation without URLs and parameters
URL: https://github.com/apache/knox/pull/226
## What changes were proposed in this pull request?
The `KNOX` service usually does not come with any `url` or `parameter` so
that we should allow this service to be added in the generated topology without
these attributes.
## How was this patch tested?
Updated and ran JUnit tests.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 361476)
Remaining Estimate: 0h
Time Spent: 10m
> KNOX service should be added during topology generation
> -------------------------------------------------------
>
> Key: KNOX-2154
> URL: https://issues.apache.org/jira/browse/KNOX-2154
> Project: Apache Knox
> Issue Type: Bug
> Components: Server
> Affects Versions: 1.4.0
> Reporter: Sandor Molnar
> Assignee: Sandor Molnar
> Priority: Major
> Fix For: 1.4.0
>
> Time Spent: 10m
> Remaining Estimate: 0h
>
> Currently, the {{manager}}, {{admin}} and {{knoxsso}} topologies are released
> together with Knox. If we wanted to replace them with providers/descriptors
> we should create similar descriptors to these:
> {code:java}
> {
> "provider-config-ref": "manager",
> "services": [
> {
> "name": "KNOX"
> }
> ],
> "applications": [
> {
> "name": "admin-ui"
> }
> ]
> } {code}
> {code:java}
> {
> "provider-config-ref": "admin",
> "services": [
> {
> "name": "KNOX"
> }
> ]
> } {code}
> {code:java}
> {
> "provider-config-ref": "knoxsso",
> "services": [
> {
> "name": "KNOXSSO",
> "params": {
> "knoxsso.cookie.secure.only": "true",
> "knoxsso.token.ttl": "86400000"
> }
> }
> ],
> "applications": [
> {
> "name": "knoxauth"
> }
> ]
> }{code}
>
> As you can see, in case of {{manager}} and {{admin}} descriptors the {{KNOX}}
> service does not have neither any {{url}} nor any {{parameter}} defined. This
> will result in the {{KNOX}} service being excluded from the generated
> topology -> the Admin API/UI won't work as expected.
> Recommended solution: allow the {{KNOX}} service to be included even if there
> is no {{url/param}} set in the descriptor.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
