risdenk commented on a change in pull request #227: KNOX-2155 - KnoxSSO should
handle multiple cookies with the same name
URL: https://github.com/apache/knox/pull/227#discussion_r360536219
##########
File path:
gateway-adapter/src/main/java/org/apache/hadoop/gateway/provider/federation/jwt/filter/SSOCookieFederationFilter.java
##########
@@ -38,18 +38,6 @@ protected void handleValidationError(HttpServletRequest
request,
super.handleValidationError(request, response, status, error);
}
- /**
- * Encapsulate the acquisition of the JWT token from HTTP cookies within the
- * request.
- *
- * @param req servlet request to get the JWT token from
- * @return serialized JWT token
- */
- @Override
- protected String getJWTFromCookie(HttpServletRequest req) {
- return super.getJWTFromCookie(req);
- }
-
Review comment:
Will this break backwards compat if someone upgrades? I don't quite
understand how these adapter classes work.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
