[
https://issues.apache.org/jira/browse/KNOX-2157?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17006780#comment-17006780
]
Kevin Risden commented on KNOX-2157:
------------------------------------
Not sure curl is the best option. Should be cross platform.
Also admin api is password protected. Would probably be better to have some
internal check to return after Knox is fully up. Maybe Java to check the port
is up?
Not sure it seems like there are some rough issues here with how Knox is
currently launched.
> Knox should check if it's actually up&running
> ---------------------------------------------
>
> Key: KNOX-2157
> URL: https://issues.apache.org/jira/browse/KNOX-2157
> Project: Apache Knox
> Issue Type: New Feature
> Components: Server
> Affects Versions: 1.1.0, 1.2.0, 1.3.0
> Reporter: Sandor Molnar
> Assignee: Sandor Molnar
> Priority: Major
> Fix For: 1.4.0
>
>
> As of now, Knox returns a success code in case the process is being created.
> There should be another way to check if the server is actually up&running and
> is capable of serving incoming requests.
> My proposal is:
> * the Knox startup script should be modified to run a basic Admin API check
> in case {{--test-gateway-url}} is defined in the startup command. If this is
> blank or non-defined we fallback to the existing PID-based check
> * two more optional arguments will be defined for this feature:
> ** {{--test-gateway-retry-attempts}}: indicates the number of tries the
> startup script should execute before it fails. Defaults to 5.
> ** {{--test-gateway-retry-sleep}}: the amount of time that the test process
> will wait or sleep before a retry is issued. Defaults to 2s.
> The new-style check will use {{curl}} and will return success in case
> {{$GATEWAY_TEST_URL/gateway/admin/api/v1/version/}} returns an HTTP response
> with code 200. If this is not true; the startup script should return an error
> code.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
