risdenk commented on a change in pull request #231: KNOX-2128 - Custom 
DataSource and SQL Commands for KnoxShell and KnoxShellTable
URL: https://github.com/apache/knox/pull/231#discussion_r363336712
 
 

 ##########
 File path: gateway-shell-release/home/bin/knoxshell.sh
 ##########
 @@ -81,7 +81,7 @@ function main {
 
    checkJava
    buildAppJavaOpts
-   $JAVA "${APP_JAVA_OPTS[@]}" 
-javaagent:"$APP_BIN_DIR"/../lib/aspectjweaver.jar -jar "$APP_JAR" "$@" || exit 
1
+$JAVA "${APP_JAVA_OPTS[@]}" 
-Dlog4j.configuration=conf/knoxshell-log4j.properties 
-javaagent:"$APP_BIN_DIR"/../lib/aspectjweaver.jar -cp "$APP_JAR":lib/* 
org.apache.knox.gateway.shell.Shell "$@" || exit 1
 
 Review comment:
   Indentation

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to