[
https://issues.apache.org/jira/browse/KNOX-2160?focusedWorklogId=369144&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-369144
]
ASF GitHub Bot logged work on KNOX-2160:
----------------------------------------
Author: ASF GitHub Bot
Created on: 09/Jan/20 16:36
Start Date: 09/Jan/20 16:36
Worklog Time Spent: 10m
Work Description: pzampino commented on pull request #233: KNOX-2160 -
Monitoring and processing refreshable service parameters
URL: https://github.com/apache/knox/pull/233#discussion_r364822488
##########
File path:
gateway-server/src/main/java/org/apache/knox/gateway/config/impl/GatewayConfigImpl.java
##########
@@ -233,6 +233,12 @@
static final String REMOTE_ALIAS_SERVICE_CONFIG_PREFIX =
GATEWAY_CONFIG_FILE_PREFIX + ".remote.alias.service.config.prefix";
static final String REMOTE_ALIAS_SERVICE_CONFIG_PREFIX_DEFAULT =
GATEWAY_CONFIG_FILE_PREFIX + ".remote.alias.service.config.";
+ public static final String REFRESHABLE_SERVIVCE_PARAMETERS_FILENAME =
"refreshable-service-parameters.xml";
+ private static final String REFRESHABLE_SERVICE_PARAMETERS_FOLDER =
GATEWAY_CONFIG_FILE_PREFIX + ".refreshable.service.parameters.folder";
+ private static final String
REFRESHABLE_SERVICE_PARAMETERS_FOLDER_MONITORING_INTERVAL =
GATEWAY_CONFIG_FILE_PREFIX
+ + ".refreshable.service.parameters.folder.monitor.interval";
+ private static final int
REFRESHABLE_SERVICE_PARAMETERS_FOLDER_MONITORING_INTERVAL_DEFAULT = 60000;
Review comment:
I thought an existing file monitor is being re-used, but this implies a new
monitor.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 369144)
Time Spent: 20m (was: 10m)
> Monitoring and process refreshable service parameters in Knox
> -------------------------------------------------------------
>
> Key: KNOX-2160
> URL: https://issues.apache.org/jira/browse/KNOX-2160
> Project: Apache Knox
> Issue Type: New Feature
> Components: Server
> Affects Versions: 1.1.0, 1.2.0, 1.3.0
> Reporter: Sandor Molnar
> Assignee: Sandor Molnar
> Priority: Major
> Fix For: 1.4.0
>
> Time Spent: 20m
> Remaining Estimate: 0h
>
> It'd be beneficial if there was a way to update service parameters in a
> descriptor without using the Admin API/UI. The preferred approach is
> described as follows. I'd add 2 new configurations:
> - {{refreshable.service.parameters.folder}} - optional configuration to
> indicate if Knox should monitor the given folder for service parameter
> changes. If it's {{null}} -> no monitoring is enabled.
> - {{refreshable.service.parameters.folder.monitor.interval}} - indicates the
> time period Knox checks if any parameter changes were made; defaults to 60
> seconds. This is relevant only if {{refreshable.service.parameters.folder}}
> is {{not null}}.
> A new monitor would be implemented (triggered only if monitoring is enabled)
> as follows:
> # checks {{refreshable-service-parameters.xml}} within the configured
> {{refreshable.service.parameters.folder}}. The relevant configuration's name
> is {{refreshable.service.parameters}}.
> # if there is new content (based on file timestamp) -> parse the file and
> build a new parameter list -> trigger topology redeployment with the new
> parameter list by rewriting the appropriate descriptor file.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
