[
https://issues.apache.org/jira/browse/KNOX-2186?focusedWorklogId=373074&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-373074
]
ASF GitHub Bot logged work on KNOX-2186:
----------------------------------------
Author: ASF GitHub Bot
Created on: 16/Jan/20 15:53
Start Date: 16/Jan/20 15:53
Worklog Time Spent: 10m
Work Description: risdenk commented on pull request #238: KNOX-2186 -
Advanced service discovery configuration handling
URL: https://github.com/apache/knox/pull/238#discussion_r367496635
##########
File path:
gateway-cm-integration/src/main/java/org/apache/knox/gateway/SupportedService.java
##########
@@ -0,0 +1,87 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with this
+ * work for additional information regarding copyright ownership. The ASF
+ * licenses this file to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance with the License.
+ * You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS, WITHOUT
+ * WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the
+ * License for the specific language governing permissions and limitations
under
+ * the License.
+ */
+package org.apache.knox.gateway;
+
+import static java.util.Collections.emptySet;
+import static java.util.Collections.singleton;
+
+import java.util.Set;
+
+public enum SupportedService {
Review comment:
So I don't quite understand the purpose of this. I left a comment on the
Jira about how dependencies between services isn't specific to CM. I don't know
why certain services would be listed here. This seems brittle to have to keep
up to date.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 373074)
Time Spent: 20m (was: 10m)
> Cloudera Manager integration - filter services
> ----------------------------------------------
>
> Key: KNOX-2186
> URL: https://issues.apache.org/jira/browse/KNOX-2186
> Project: Apache Knox
> Issue Type: New Feature
> Components: Server
> Affects Versions: 1.4.0
> Reporter: Sandor Molnar
> Assignee: Sandor Molnar
> Priority: Major
> Fix For: 1.4.0
>
> Time Spent: 20m
> Remaining Estimate: 0h
>
> With KNOX-2160, Knos is capable of processing a Hadoop XML configuration file
> and turn its content into Knox providers.
> It'd be beneficial to add support for the following use cases that are also
> Cloudera Manager integration specific:
> *1.)* Cloudera Manager reports if auto-discovery is {{enabled}} for each
> known services. That is, a list of boolean properties can be generated by CM
> indicating if {{SERVICE_X}} is enabled or not in the following form:
> {{gateway.auto.discovery.enabled.SERVICE_NAME=[true|false]}}
> The new Hadoop XML configuration parser should take this information into
> account, and add a certain service into the generated Knox descriptor only if
> that service is explicitly {{enabled}} or there is no boolean flag within the
> CM generated properties with that service name (indicating an unknown -
> custom - service)
> *2.)* There are some services - mainly UI services - that are not working
> without some more required services in place (mainly their API counterpart).
> For instance: {{RANGERUI}} won't work properly if {{RANGER}} is not available.
> The new Hadoop XML configuration parser should be modified to not to add any
> service into the generated Knox descriptor unless
> * all required services are available (if any)
> * all required services are enabled (see the previous point)
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
